PRB: CScrollView::FillOutsideRect() Fills Incorrectly

CAUSE

In the file VIEWSCRL.CPP, in the Visual C++ MFC\SRC directory, FillOutsideRect() has the following implementation:

   void CScrollView::FillOutsideRect(CDC* pDC, CBrush* pBrush)
   {
      ASSERT_VALID(pDC);
      ASSERT_VALID(pBrush);
      // Fill Rect outside the image
      CRect rect;
      GetClientRect(rect);
      ASSERT(rect.left == 0 && rect.top == 0);
      rect.left = m_totalDev.cy;
      if (!rect.IsRectEmpty())
         pDC->FillRect(rect, pBrush);    // vertical strip along the side
      rect.left = 0;
      rect.right = m_totalDev.cy;
      rect.top = m_totalDev.cy;
      if (!rect.IsRectEmpty())
         pDC->FillRect(rect, pBrush);    // horizontal strip along the
                                         // bottom

   }
				

This implementation is incorrect because it sets rect.left and rect.right to "m_totalDev.cy", instead of setting them equal to "m_totalDev.cx".

This causes the first rectangle filled to have its left border begin at the coordinate "m_totalDev.cy" (the bottom border of the scrollable area of the view) when it should be at the coordinate of the right border of the view (that is, "m_totalDev.cx"). Similarly, the second rectangle filled has its right border ending at the coordinate "m_totalDev.cy" (always the bottom border of the scrollable area of the view) when it should be at the coordinate of the right border of the view.

   rect.left = m_totalDev.cx;
   rect.right = m_totalDev.cx;
				

   BOOL CDibView::OnEraseBkgnd(CDC* pDC)
   {
      CBrush br( GetSysColor( COLOR_ACTIVECAPTION ) );
      FillOutsideRect( pDC, &br );
      return TRUE;                   // Erased
   }
				

   (BitmapWidth) < x < (BitmapWidth) + (BitmapHeight - BitmapWidth)
   (0)           < y < (BitmapHeight)