From:	ADVAX::"mcnc!VM1.NoDak.EDU!gih900%SAO.AARNET.EDU.AU" 18-JUN-1990 18:44:45.63
To:	Multiple recipients of list ANU-NEWS <ANU-NEWS@NDSUVM1>
CC:	
Subj:	Re: Problems with V6 beta (repost)

Received: by ADVAX.DECnet (utk-mail11 v1.5) ; Mon, 18 Jun 90 18:47:24 EDT
Received:  from mcnc by ge-dab.GE.COM (5.61/GE-DAB 1.12) with UUCP
	id AA03618 for everhart; Mon, 18 Jun 90 18:46:47 -0400
Received: from VM1.NoDak.EDU by mcnc.mcnc.org (5.59/MCNC/5-16-88)
	id AA10427; Fri, 15 Jun 90 15:33:43 EDT
Message-Id: <9006151933.AA10427@mcnc.mcnc.org>
Received: from NDSUVM1.BITNET by VM1.NoDak.EDU (IBM VM SMTP R1.2.1MX) with BSMTP id 5941; Fri, 15 Jun 90 14:32:14 CDT
Received: from NDSUVM1.BITNET by NDSUVM1.BITNET (Mailer R2.07) with BSMTP id
 5935; Fri, 15 Jun 90 14:32:13 CDT
Date:         Thu, 14 Jun 90 22:57:42 GMT
Reply-To: mcnc!VM1.NoDak.EDU!gih900%SAO.AARNET.EDU.AU
Sender: ANU-NEWS Discussion <ANU-NEWS@VM1.NoDak.EDU>
From: mcnc!VM1.NoDak.EDU!gih900%SAO.AARNET.EDU.AU
Subject:      Re: Problems with V6 beta (repost)
To: Multiple recipients of list ANU-NEWS <ANU-NEWS@NDSUVM1>
 
I'm not sure what happened to this posting, but when I got it back via the
mailing list all the interesting bits were chopped off, so I'll repost:...
 
In article <1990Jun13.164112.1@rogue.llnl.gov>, oberman@rogue.llnl.gov writes:
> I want to make sure that this the appropriate forum for posting messages on
> problems with V6. (Since it's not yet officially released.)
>
> If so, I have another nasty one. Once again, running as a client. the NEWS
> image crashes with an ACCESS VIOLATION when I try to post to
> COMP.dcom.telecom.
> Since this is, I believe, a moderated group, I wonder if there might be a
> problem on client posts to moderated groups. In client mode, the post should
> simply be sent to the server who should post or mail as required. I supect
> that
> something else is happening.
 
correct - the code gets a nonexistant moderator address
(i.e a char* value of 0) then attempts a strcmp call - presto instant accvio.
 
The change in NEWSPOST.C to prevent this accvio is as follows:
 
do_posting()
{
 ...
 
    /* check if this posting is by the moderator of a newsgroup,
       and if so, whether there is further moderation required,
       or if the posting can happen now */
 
  sprintf(mod_address,"%s@%s",usr_username,Node_address);
  *post_address = '\0';
  cp1 = ngroup;
  while ((cp1) && (*cp1)) {
    if (cp2 = strchr(cp1,',')) *cp2 = '\0';
    util_cvrt(lg,cp1);
    if (cp2) *cp2++ = ',';
    if ((g = ga_exact_name(lg)) && (ga[g]->grp_flags & NEWS_M_MAILLIST)) {
      char infile_name[257],
           *pa;
 
      if (fgetname(fpr,infile_name)) {
        fclose(fpr);
        if (pa = moderator_address(ga[g]->grp_name)) {
          sprintf(err_oline,"Post to %s List-Server (%s)",ga[g]->grp_name,pa);
          call_mail(infile_name,&subj_line[9],add_transform(pa),err_oline);
          fpr = fopen(infile_name,"r");
          }
        else if (!nntp_client) {
          sprintf(err_oline,"No maillist server address for group %s",
              ga[g]->grp_name);
          err_line(err_oline);
          }
        }
      }
    else if (g && (ga[g]->grp_flags & NEWS_M_MAILMODERATE)) {
      if (pa = moderator_address(ga[g]->grp_name)) {
        if (strcmp(mod_address,pa)) {
          strcpy(post_address,pa);
          break;
          }
        else approval_required = 1;
        }
      }
    cp1 = cp2;
    }
  c$cks(1);
 
  ...
}
 
the change is a check for a null return from moderator_address() before using
the returned value. There are also associated similar changes to NEWSSETSHOW.C
which will be included once I finally get sufficient time to package up a
distribution.
 
>Also, when I enter NEWS, I find my pointer pointing to some odd group which is
>not registered. A dir/reg or dir/new also leaves the pointer in some strange
>location. Once I actually select a group, the pointer is pointing at the first
>unread message.
 
This is one I cannot reproduce here.
 
cheers,
 
Geoff
gih900@sao.aarnet.edu.au